Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging handler #56

Closed
jantman opened this issue Aug 12, 2015 · 6 comments
Closed

logging handler #56

jantman opened this issue Aug 12, 2015 · 6 comments
Labels
bug
Milestone
0.1.1

Comments

@jantman
Copy link
Owner

jantman commented Aug 12, 2015

If awslimitchecker is used via python without defining a logging handler, we get the "no handers found" error. Fix this.
@jantman jantman added the bug label Aug 12, 2015
@jantman jantman added this to the 0.1.1 milestone Aug 12, 2015
@jantman
Copy link
Owner Author

jantman commented Aug 13, 2015

When that happens, it also suppresses the AGPL message.

Desired state:

  1. AGPL message is displayed in ALL cases, period.
  2. awslimitchecker works nicely/correctly when used as a Python library
  3. even if there's no root logger defined

jantman added a commit that referenced this issue Aug 13, 2015
@jantman
issue #56 - AGPL warning in checker.__init__ should write to STDERR, …
118bb28 
…not logging
@jantman
Copy link
Owner Author

jantman commented Aug 13, 2015

part 1 is fixed in 118bb28.

@jantman
Copy link
Owner Author

jantman commented Aug 13, 2015

Need to document how to:

  1. use awslimitchecker logging with a program that defines a root-level logger (and optionally suppress logging below a certain level)
  2. use awslimitchecker logging with a program that does not define a root-level logger (i.e. configures its own logger and handlers)

@jantman
Copy link
Owner Author

jantman commented Aug 13, 2015

also, move suppression of boto logging to runner

jantman added a commit that referenced this issue Aug 13, 2015
@jantman
issue #56 - document how to set up logging for awslimitchecker
b7aeee8
jantman added a commit that referenced this issue Aug 13, 2015
@jantman
fixes #56 - dont muck with other libraries' logging in our library; m…
f46c8ba 
…ove the boto logging stuff to runner
@jantman
Copy link
Owner Author

jantman commented Aug 13, 2015

#60 for fix

jantman added a commit that referenced this issue Aug 13, 2015
@jantman
Merge pull request #60 from /issues/56
8fa6364 
Issues/56
@jantman jantman closed this as completed Aug 13, 2015
@jantman
Copy link
Owner Author

jantman commented Aug 13, 2015

This has been released in 0.1.1, which is now live on pypi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.1.1
Development

No branches or pull requests
1 participant
@jantman