Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect 'VPC security groups per Region' usage #518

Closed
aperov9 opened this issue Jan 8, 2021 · 1 comment
Closed

Incorrect 'VPC security groups per Region' usage #518

aperov9 opened this issue Jan 8, 2021 · 1 comment

Comments

@aperov9
Copy link

aperov9 commented Jan 8, 2021

Bug Report

The 'VPC security groups per Region' usage value is not correct in combination with VPC sharing. In tested account the result['EC2']['VPC security groups per Region'].get_current_usage()[0].get_value() returns a value over 2500 although there was no quota increase. (default limit is 2500)

Version

awslimitchecker version 10.0.0

Expected Output

Awslimitchecker should not count all VPC security groups available in a region for one account. This number includes SGs that are owned by other accounts if the VPC is shared between accounts. For the correct number of SGs, it should be filtered by the owner account.

Testing Assistance

I'm able to assist in testing pre-release.

aperov9 added a commit to aperov9/awslimitchecker that referenced this issue Jan 9, 2021
@jantman
Copy link
Owner

jantman commented Aug 4, 2021

A fix for this has been released in 12.0.0, which is now live on PyPI and Docker Hub. Thank you so much!

@jantman jantman closed this as completed Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants