Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PyPI version check URL #352

Closed
jantman opened this issue Jul 29, 2018 · 1 comment
Closed

Fix PyPI version check URL #352

jantman opened this issue Jul 29, 2018 · 1 comment

Comments

@jantman
Copy link
Owner

jantman commented Jul 29, 2018

The utils._get_latest_version method called in AwsLimitChecker.init uses an old PyPI URL. Update the URL to https://pypi.org/pypi/awslimitchecker/json

While we're at it, also set the User-Agent per PyPI's guidelines.
@jantman jantman added the ready label Jul 29, 2018
jantman added a commit that referenced this issue Jul 29, 2018
@jantman
Issue #352 - CHANGELOG for previous commit
af0f060
@jantman
Copy link
Owner Author

jantman commented Jul 30, 2018

This was released in 5.0.0 just now, and should be live on PyPI.

nadlerjessie pushed a commit to nadlerjessie/awslimitchecker that referenced this issue Feb 16, 2019
@jantman @nadlerjessie
Fixes jantman#352 - fix PyPI version check URL and set user-agent string
815ac60
nadlerjessie pushed a commit to nadlerjessie/awslimitchecker that referenced this issue Feb 16, 2019
@jantman @nadlerjessie
Issue jantman#352 - CHANGELOG for previous commit
bbc9144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jantman