Skip to content

Commit

Permalink
Merge pull request #391 from bergkampsliew/develop
Browse files Browse the repository at this point in the history
Update DynamoDB and EFS limits #390
  • Loading branch information
jantman authored Feb 26, 2019
2 parents aef5405 + 813b9bf commit 77414e6
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion awslimitchecker/services/dynamodb.py
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ def get_limits(self):
limits['Global Secondary Indexes'] = AwsLimit(
'Global Secondary Indexes',
self,
5,
20,
self.warning_threshold,
self.critical_threshold,
limit_type='AWS::DynamoDB::Table',
Expand Down
2 changes: 1 addition & 1 deletion awslimitchecker/services/efs.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def get_limits(self):
limits['File systems'] = AwsLimit(
'File systems',
self,
125,
1000,
self.warning_threshold,
self.critical_threshold,
limit_type='AWS::EFS::FileSystem',
Expand Down
4 changes: 2 additions & 2 deletions awslimitchecker/tests/services/test_dynamodb.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def se_conn(cls):
assert read_capacity_table.limit_type == 'AWS::DynamoDB::Table'
global_secondary_index = limits['Global Secondary Indexes']
assert global_secondary_index.limit_type == 'AWS::DynamoDB::Table'
assert global_secondary_index.default_limit == 5
assert global_secondary_index.default_limit == 20
local_secondary_index = limits['Local Secondary Indexes']
assert local_secondary_index.limit_type == 'AWS::DynamoDB::Table'
assert local_secondary_index.default_limit == 5
Expand Down Expand Up @@ -144,7 +144,7 @@ def se_conn(cls):
assert read_capacity_table.limit_type == 'AWS::DynamoDB::Table'
global_secondary_index = limits['Global Secondary Indexes']
assert global_secondary_index.limit_type == 'AWS::DynamoDB::Table'
assert global_secondary_index.default_limit == 5
assert global_secondary_index.default_limit == 20
local_secondary_index = limits['Local Secondary Indexes']
assert local_secondary_index.limit_type == 'AWS::DynamoDB::Table'
assert local_secondary_index.default_limit == 5
Expand Down
8 changes: 4 additions & 4 deletions awslimitchecker/tests/services/test_efs.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def test_get_limits(self):
assert res['File systems'].service == cls
assert res['File systems'].def_warning_threshold == 21
assert res['File systems'].def_critical_threshold == 43
assert res['File systems'].default_limit == 125
assert res['File systems'].default_limit == 1000

def test_update_limits_from_api(self):
mock_conn = Mock()
Expand All @@ -93,7 +93,7 @@ def test_update_limits_from_api(self):
'File systems': AwsLimit(
'File systems',
cls,
125,
1000,
cls.warning_threshold,
cls.critical_threshold,
limit_type='AWS::EFS::FileSystem',
Expand All @@ -102,7 +102,7 @@ def test_update_limits_from_api(self):
cls._update_limits_from_api()
assert mock_connect.mock_calls == [call()]
assert mock_conn.mock_calls == []
assert cls.limits['File systems'].default_limit == 125
assert cls.limits['File systems'].default_limit == 1000

def test_update_limits_from_api_us_east_1(self):
mock_conn = Mock()
Expand All @@ -116,7 +116,7 @@ def test_update_limits_from_api_us_east_1(self):
'File systems': AwsLimit(
'File systems',
cls,
125,
1000,
cls.warning_threshold,
cls.critical_threshold,
limit_type='AWS::EFS::FileSystem',
Expand Down

0 comments on commit 77414e6

Please sign in to comment.