Added support for minification using html-minifier

[sebastienbarre]

I discovered html-webpack-plugin today, great tool, thanks.

This PR adds a minify option (true or an options object), which enables the minification of all resulting HTML files, using kangax/html-minifier. This comes handy when you are working on your own (unminified) template file, but want the smallest final output for performance.

Please note that html-minifier is very conservative by default, as most of its options are set to false.
I suggest using these for example:

  var HtmlWebpackPlugin = require('html-webpack-plugin');
  var html_webpack_options = {
    template: 'src/assets/index.template.html'
  };
  if (production) {
    html_webpack_options.minify = {
      removeComments: true,
      collapseWhitespace: true,
      conservativeCollapse: true,
      minifyJS: true,
      minifyCSS: true
    };
  }
  config.plugins.push(new HtmlWebpackPlugin(html_webpack_options));

Hope this helps.

[sebastienbarre]

Howdy. Anything else you would like me to add or fix there? Thanks.

[ampedandwired]

This looks pretty good. Is it perhaps possible to add a test or two and rebase?

[sebastienbarre]

@ampedandwired I rebased, but I can't get your tests to run. It assumes jshint and jasmine-node are globally installed, which was easy enough to do, but is still failing:

> jshint -c .jshintrc *.js spec && jasmine-node --captureExceptions spec

Exception loading: /Volumes/Users/Shared/Src/react/html-webpack-plugin/spec/HtmlWebpackPluginSpec.js
{ [Error: Cannot find module 'tapable'] code: 'MODULE_NOT_FOUND' }
Error: Cannot find module 'tapable'

I have webpack and tapable globally installed too.

[jantimon]

@sebastienbarre I created a new feature branch for this pr:
https://github.com/ampedandwired/html-webpack-plugin/tree/feature/htmlmin

As soon as we got tests it should be ready to merge

To run the tests just use npm test.

[sebastienbarre]

@jantimon Thanks. That's what I did, npm test. There are missing devDependencies, but I installed them globally, as mentioned above. It is still failing to run on my Mac as is though.

[SimenB]

@sebastienbarre I'm on a Mac, and running npm i && npm t works fine.

$ npm -g ls --depth 0
/Users/simen/.nvm/versions/node/v0.12.2/lib
├── [email protected] -> /Users/simen/Development/csslint-stylish
├── [email protected] -> /Users/simen/Development/grunt-contrib-csslint
├── [email protected] -> /Users/simen/Development/gulp-amdcheck
├── [email protected] -> /Users/simen/Development/gulp-csslint
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]

[sebastienbarre]

Thanks guys. I deleted my node_modules directory, re-installed, and tests are now passing. Maybe a glitch during a transition to iojs. I'll work on adding a test.

[SimenB]

@sebastienbarre You should look at how html-loader does it, it picks up whether to minify from the environment if it's not explicit in its options. Not sure if there's a difference between a loader and a plugin though.
https://github.com/webpack/html-loader/blob/master/index.js#L59

(This as well as my own #32 would be obsolete if #10 were implemented, as we could just pass it through html-loader.)

[lock]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.