add testnet4 support #699
add testnet4 support #699
Conversation
I think testnet3 should be supported alongside testnet4 for a while. I'm still using it. as it's a good way to smoke test in extreme conditions. |
mm yea, i've been trying to reduce the formatting changes but i have no clue what @janoside is using so i can keep it consistent x3 |
0xf0xx0
force-pushed
the
tesseract-net-4
branch
2 times, most recently
from
9ea24af to
0066db4
Compare
|
THERE |
| "test": "#8f9a22", | ||
| "testnet4": "#1daf00", |
There was a problem hiding this comment.
I wonder why do you change the testnet3 coin color at this point? I think both testnet3 & 4 could use the same color green.
And also I wonder if this also changes the color of the favicon, which follows coin color as well in order to visually distinguish browser tabs.
There was a problem hiding this comment.
i picked a color between mainnet and testnet to make the explorer icons visually distinct, but now that i look closer it doesnt look like these colors are even used. the favicons are hardcoded in their respective .svgs, and the tab color is hardcoded here: https://github.com/janoside/btc-rpc-explorer/blob/153aa0ae7f902562bd1cfa2bbcea4c00026e5aef/views/layout.pug#L49C45-L50C1
0xf0xx0
force-pushed
the
tesseract-net-4
branch
from
0066db4 to
b4b0ac7
Compare
…stnet4 to site demo list
0xf0xx0
force-pushed
the
tesseract-net-4
branch
from
b4b0ac7 to
3641dce
Compare
this adds testnet4 alongside testnet3, but since testnet3 is deprecated, should its info be replaced with testnet4 info? also, have i missed anything?
closes #666