-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend model metadata schema #86
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make keys targets, test_task, train_task required
…odel-metadata.d.ts
discovered broken for alignn_checkpoint
…model metadata files
…add labels to all Keys
fix typo in mace.yml + gnome.yml remove non-parametric option for model_params
refactor make_metrics_tables.py to load all metadata from model yaml files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second major reworking of model metadata schema, validation, and syncing types to site following #85.
Adds keys
train_task
test_task
targets
model_type
model_params
and disallow keys not defined in schema.2517f55 convert model-metadata-schema from .json to .yaml
69ffe3c add train_size model_params openness to Key enum
ec3e828 fix loading multiple metadata files per model dir in models.py
f44f065 move TS defs into separate src/lib/types.ts file
484562f package.json add dev dep json-schema-to-typescript to auto-generate model-metadata.d.ts
f33c5fd mv model-metadata-schema.y(a->'')ml
e6b1c5e fix load() util for model checkpoint loading
4e60e96 add keys train_task test_task targets model_type model_params to all model metadata files
cdf840d add model_params to wandb-collected run params in all test scripts
80a494c rename DictableStrEnum->LabelEnum, add ability to set key labels and add labels to all Keys
86ae825 set additionalProperties: false on model_metadata_schema.yml
330b343 add model params col to metrics table
0ce580b change MP v2022.10.28 model training set titles
d4ed313 fix model openness toggle, ModelCard remove DOI from model links