fix(op_crates/web): make TextEncoder work with forced non-strings (de…

…noland#8206) Fixes: denoland#8201
jannes · Dec 1, 2020 · 8fe643e · 8fe643e
1 parent 6e1a2eb
commit 8fe643e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/cli/tests/unit/text_encoding_test.ts b/cli/tests/unit/text_encoding_test.ts
@@ -210,3 +210,17 @@ unitTest(function toStringShouldBeWebCompatibility(): void {
   const decoder = new TextDecoder();
   assertEquals(decoder.toString(), "[object TextDecoder]");
 });
+unitTest(function textEncoderShouldCoerceToString(): void {
+  const encoder = new TextEncoder();
+  const fixutreText = "text";
+  const fixture = {
+    toString() {
+      return fixutreText;
+    },
+  };
+
+  const bytes = encoder.encode(fixture as unknown as string);
+  const decoder = new TextDecoder();
+  const decoded = decoder.decode(bytes);
+  assertEquals(decoded, fixutreText);
+});
diff --git a/op_crates/web/08_text_encoding.js b/op_crates/web/08_text_encoding.js
@@ -1061,6 +1061,7 @@
   class TextEncoder {
     encoding = "utf-8";
     encode(input = "") {
+      input = String(input);
       // Deno.core.encode() provides very efficient utf-8 encoding
       if (this.encoding === "utf-8") {
         return core.encode(input);