Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement clojure.core/sort #218

Merged
merged 6 commits into from
Jan 30, 2025
Merged

Implement clojure.core/sort #218

merged 6 commits into from
Jan 30, 2025

Conversation

bpiel
Copy link
Contributor

@bpiel bpiel commented Jan 30, 2025

Issue: #178

Examples:

clojure.core=> (sort [3 2 1])
(1 2 3)
clojure.core=> (meta (sort ^:a [4 3 2]))
{:a true}
clojure.core=> (sort '(4 3 2))
(2 3 4)
clojure.core=> (sort [[4] [3] [2]])
([2] [3] [4])
clojure.core=> (type (sort []))
"native_vector_sequence"

Copy link
Member

@jeaye jeaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just some small comments.

@CLAassistant
Copy link

CLAassistant commented Jan 30, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@jeaye jeaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Have you tested this in a jank repl session?

You might be interested in adding tests for sort over here: https://github.com/jank-lang/clojure.core-test Not required, since we have others also working on tests there.

@bpiel
Copy link
Contributor Author

bpiel commented Jan 30, 2025

@jeaye

Have you tested this in a jank repl session?

Yes. I pasted examples in the original PR description above of some of the repl testing I did.
I can add tests to that repo too.

@jeaye jeaye merged commit 4239ee5 into jank-lang:main Jan 30, 2025
7 checks passed
@jeaye
Copy link
Member

jeaye commented Jan 30, 2025

Nice job, Bill!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants