-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement clojure.core/sort #218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Just some small comments.
compiler+runtime/include/cpp/jank/runtime/obj/native_vector_sequence.hpp
Outdated
Show resolved
Hide resolved
compiler+runtime/src/cpp/jank/runtime/obj/native_vector_sequence.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Have you tested this in a jank repl session?
You might be interested in adding tests for sort
over here: https://github.com/jank-lang/clojure.core-test Not required, since we have others also working on tests there.
Yes. I pasted examples in the original PR description above of some of the repl testing I did. |
Nice job, Bill! |
Issue: #178
Examples: