Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render slow on device label #4627

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Feb 11, 2025

Describe Your Changes

This pull request includes a modification to the ModelLabel component to adjust the calculation of available RAM and add a debug log.

Changes to ModelLabel component:

  • web/containers/ModelLabel/index.tsx: Adjusted the calculation of availableRam to account for the size of the active model's metadata more accurately by converting it to megabytes and applying a multiplier. Added a console.log statement to log the size of the active model's metadata for debugging purposes.

Fixes Issues

before active a model
CleanShot 2025-02-11 at 15 04 09

After active a model, we calculate model size into availableRam

CleanShot 2025-02-11 at 15 04 25

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added this to the v0.5.15 milestone Feb 11, 2025
@urmauur urmauur requested a review from louis-menlo February 11, 2025 08:10
@urmauur urmauur self-assigned this Feb 11, 2025
@urmauur urmauur added the type: bug Something isn't working label Feb 11, 2025
Copy link
Contributor

@louis-menlo louis-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Barecheck - Code coverage report

Total: 67.97%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web/containers/ModelLabel/index.tsx54

Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@urmauur urmauur merged commit 6a87b73 into release/v0.5.15 Feb 11, 2025
21 checks passed
@urmauur urmauur deleted the fix/label-slow-on-device branch February 11, 2025 08:36
@github-actions github-actions bot modified the milestones: v0.5.15, v0.5.17 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants