Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter out fake gpu #4617

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix: filter out fake gpu #4617

merged 1 commit into from
Feb 10, 2025

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Feb 10, 2025

Describe Your Changes

This pull request includes an important change to the appService in the web/services/appService.ts file. The change ensures that only GPUs with a total VRAM greater than 0 are included in the gpuSettingInfo.

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: bug Something isn't working label Feb 10, 2025
@urmauur urmauur added this to the v0.5.15 milestone Feb 10, 2025
@urmauur urmauur requested a review from louis-menlo February 10, 2025 13:33
@urmauur urmauur self-assigned this Feb 10, 2025
Copy link
Contributor

Barecheck - Code coverage report

Total: 67.75%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web/services/appService.ts58

Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@urmauur urmauur merged commit 386d410 into release/v0.5.15 Feb 10, 2025
21 checks passed
@urmauur urmauur deleted the fix/filter-out-fake-gpu branch February 10, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants