chore: ensure app Id is maintained #4541
Merged
+36
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-menlo
temporarily deployed
to
production
GitHub Actions
Inactive
urmauur
approved these changes
Jan 29, 2025
Barecheck - Code coverage reportTotal: 67.86%Your code coverage diff: 0.00% ▴ Uncovered files and lines
|
|
This is the build for this pull request. You can download it from the Artifacts section here: Build URL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR ensures that the app ID remains unchanged, just like other global app settings.
Changes
This pull request introduces changes to support the management of a distinct ID within the app configuration. The most important changes include adding a new optional
distinct_idfield to theAppConfigurationtype, updating the layout to handle this distinct ID, and adding utility functions for updating and retrieving the distinct ID.Changes to support distinct ID management:
core/src/types/config/appConfigEntity.ts: Added an optionaldistinct_idfield to theAppConfigurationtype.web/containers/Layout/index.tsx: ImportedgetAppDistinctIdandupdateDistinctIdfunctions and updated theBaseLayoutcomponent to manage the distinct ID. [1] [2]web/hooks/useFactoryReset.ts: Updated theuseFactoryResethook to include thedistinct_idin the app configuration.web/utils/settings.ts: AddedupdateDistinctIdandgetAppDistinctIdfunctions to handle the distinct ID in the app configuration.