Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Update app layout with an expanded system monitor #4528

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Jan 27, 2025

Describe Your Changes

This pull request includes changes to the MainViewContainer and ThreadCenterPanel components to improve the handling of the system monitor panel's height. The changes involve moving the logic for adjusting the height based on the system monitor panel's visibility from ThreadCenterPanel to MainViewContainer.

Changes to MainViewContainer:

  • Added useEffect and useState imports to manage the height of the system monitor panel.
  • Imported showSystemMonitorPanelAtom from App.atom and added state management for the system monitor panel's height.
  • Updated the MainViewContainer component to adjust its height based on the system monitor panel's height.

Changes to ThreadCenterPanel:

  • Removed the import of showSystemMonitorPanelAtom and the related state management logic.
  • Cleaned up the ThreadCenterPanel component by removing the height adjustment logic for the system monitor panel.

Fixes Issues

Screen.Recording.2025-01-27.at.21.32.13.mov

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added this to the v0.5.15 milestone Jan 27, 2025
@urmauur urmauur requested a review from louis-menlo January 27, 2025 14:35
@urmauur urmauur self-assigned this Jan 27, 2025
@urmauur urmauur added the type: enhancement Improves a current feature label Jan 27, 2025
Copy link
Contributor

Barecheck - Code coverage report

Total: 67.99%

Your code coverage diff: 0.03% ▴

Uncovered files and lines
FileLines
web/screens/Thread/ThreadCenterPanel/index.tsx41, 43, 46, 49, 52, 82-83, 88-89, 93, 95, 98, 101-102, 110-113, 115-117, 125, 128-129, 131, 133, 139, 145-146

Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@urmauur urmauur merged commit 65c9bb9 into dev Jan 28, 2025
21 checks passed
@urmauur urmauur deleted the enhancement/app-layout-system-monitor branch January 28, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improves a current feature
Projects
None yet
2 participants