-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: better hardware setting #4471
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-menlo
approved these changes
Jan 16, 2025
This is the build for this pull request. You can download it from the Artifacts section here: Build URL. |
Barecheck - Code coverage reportTotal: 67.72%Your code coverage diff: 0.00% ▴ Uncovered files and lines |
0675652
to
a5b9cd6
Compare
a5b9cd6
to
b5191ba
Compare
3fc0326
to
143ed17
Compare
…gine management system
762995f
to
780742e
Compare
louis-menlo
pushed a commit
that referenced
this pull request
Feb 4, 2025
* feat: better hardware setting * chore: update layout * feat: better hardware setting * chore: fix title section * chore: added hardware engine management * chore: integrate gpus and enable set gpu activate * chore: update calculate ram and vram * chore: update calulate vram and ram used * fix: set active gpus * chore: fix progress bar spacing * chore: always update cache vram gpu * chore: update cpu usage percentage * chore: fix type usage cpu * chore: update ram cpus usage getsystemmonitor from new api harware engine management system * test: update test case data using hardware management extension * chore: resolve conflict lock json * chore: cleanup app services * chore: update type OperationSystemInfo * chore: update app service * chore: show list gpus on system monitor * chore: remove monitoring extension * chore: update test case app service * chore: remove unused hooks useGpusSetting * chore: remove monitor from shource index * chore: fix test core * chore: update gpu and cpu info on engine management ext * chore: fix app service test * chore: update test appService include cpu info * chore: filter gpus show or hide on system monitor based activated gpu * chore: remove unused run_mode * chore: remove tensort * chore: update check gpu run_mode * chore: handle undefined gpus * chore: cleanup PR * chore: cleanup process node error * chore: fix type
louis-menlo
pushed a commit
that referenced
this pull request
Feb 4, 2025
* feat: better hardware setting * chore: update layout * feat: better hardware setting * chore: fix title section * chore: added hardware engine management * chore: integrate gpus and enable set gpu activate * chore: update calculate ram and vram * chore: update calulate vram and ram used * fix: set active gpus * chore: fix progress bar spacing * chore: always update cache vram gpu * chore: update cpu usage percentage * chore: fix type usage cpu * chore: update ram cpus usage getsystemmonitor from new api harware engine management system * test: update test case data using hardware management extension * chore: resolve conflict lock json * chore: cleanup app services * chore: update type OperationSystemInfo * chore: update app service * chore: show list gpus on system monitor * chore: remove monitoring extension * chore: update test case app service * chore: remove unused hooks useGpusSetting * chore: remove monitor from shource index * chore: fix test core * chore: update gpu and cpu info on engine management ext * chore: fix app service test * chore: update test appService include cpu info * chore: filter gpus show or hide on system monitor based activated gpu * chore: remove unused run_mode * chore: remove tensort * chore: update check gpu run_mode * chore: handle undefined gpus * chore: cleanup PR * chore: cleanup process node error * chore: fix type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request introduces a new hardware management extension to the project. The changes include adding new types, creating new classes for managing hardware, and updating configuration files to support the new extension.
New Hardware Management Extension:
core/src/browser/extension.ts
: AddedHardware
to theExtensionTypeEnum
to support the new hardware management extension.core/src/browser/extensions/hardwareManagement.ts
: Created theHardwareManagementExtension
class with methods to get hardware information and set active GPUs.core/src/types/hardware/index.ts
: Defined new types forCpu
,Gpu
,Os
,Power
,Ram
,Storage
, andHardwareInformation
to represent hardware details.core/src/browser/extensions/index.ts
andcore/src/types/index.ts
: Exported the new hardware management-related modules. [1] [2]Configuration and Setup:
extensions/hardware-management-extension/jest.config.js
: Added Jest configuration for testing the hardware management extension.extensions/hardware-management-extension/package.json
: Created a package file for the hardware management extension with necessary scripts and dependencies.extensions/hardware-management-extension/rolldown.config.mjs
: Added Rollup configuration for building the hardware management extension.extensions/hardware-management-extension/tsconfig.json
: Added TypeScript configuration for the hardware management extension.Integration:
extensions/hardware-management-extension/src/index.ts
: Implemented theJSONHardwareManagementExtension
class to provide functionality for managing hardware, including health checks and GPU activation.web/hooks/useHardwareManagement.ts
: Added hooks for fetching hardware information and setting active GPUs using the hardware management extension.web/package.json
: Updated dependencies to include the new hardware management extension.Fixes Issues
Self Checklist