Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump engine version - update engine variant symlink and copy CUDA dependencies #4465

Merged
merged 9 commits into from
Jan 16, 2025

Conversation

louis-menlo
Copy link
Contributor

Describe Your Changes

  • This PR addressed an issue where cuda dependencies symlink require admin privileges. Also to bump engine version to the latest one.

Self Checklist

This pull request includes several updates and improvements across multiple files related to the Cortex engine version and error handling. The most important changes include updating the Cortex engine version, improving error logging, and modifying download paths.

Version Updates:

  • Updated CORTEX_ENGINE_VERSION from v0.1.43 to v0.1.46 in multiple configuration files (rolldown.config.mjs, download.bat, download.sh). [1] [2] [3] [4] [5]

Error Handling:

  • Improved error logging in symlinkEngines function by replacing console.error with log(JSON.stringify(error)) in index.ts.

Download Path Modifications:

  • Changed the download paths for CUDA binaries in download.bat and download.sh to use BIN_PATH instead of SHARED_PATH. [1] [2]

Code Cleanup:

  • Removed the createEngineSymlinks function and its invocation from index.ts. [1] [2]

Import Formatting:

  • Reformatted imports in index.ts for better readability.

@github-actions github-actions bot added the type: bug Something isn't working label Jan 16, 2025
Copy link
Contributor

github-actions bot commented Jan 16, 2025

Barecheck - Code coverage report

Total: 69.24%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@louis-menlo louis-menlo merged commit eeac4c0 into dev Jan 16, 2025
9 checks passed
@louis-menlo louis-menlo deleted the chore/log-engine-variant-symlink branch January 16, 2025 09:42
@github-actions github-actions bot added this to the v0.5.14 milestone Jan 16, 2025
@imtuyethan imtuyethan modified the milestones: v0.5.14, v0.5.15 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants