Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add chat completion field form add remote engine #4452

Merged
merged 7 commits into from
Jan 15, 2025

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Jan 15, 2025

Describe Your Changes

This pull request includes several changes to enhance the functionality of the ModalAddRemoteEngine and RemoteEngineSettings components, as well as updates to the utility functions related to engine management. The most important changes include adding support for a new chatCmpletionsUrl field, updating the UI to provide API key instructions, and adding utility functions for engine-specific URLs.

Enhancements to ModalAddRemoteEngine:

  • Added chatCmpletionsUrl field to the engineSchema validation and form default values. [1] [2]
  • Updated the form submission to include the chatCmpletionsUrl field.
  • Added a new input field for chatCmpletionsUrl in the form UI.

Enhancements to RemoteEngineSettings:

  • Added a link to the API key instructions for each engine in the settings UI.
  • Updated the "Advance Settings" toggle to use ChevronDown icon when active.

Utility function updates:

  • Added getAPIKeyInstructionURL function to return the API key instruction URL for each engine.

Fixes Issues

CleanShot 2025-01-15 at 13 34 30

CleanShot 2025-01-15 at 13 34 18

CleanShot 2025-01-15 at 13 34 16

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: chore Maintenance, operational label Jan 15, 2025
@urmauur urmauur added this to the v0.5.14 milestone Jan 15, 2025
@urmauur urmauur requested a review from louis-menlo January 15, 2025 06:43
@urmauur urmauur self-assigned this Jan 15, 2025
Copy link
Contributor

github-actions bot commented Jan 15, 2025

Barecheck - Code coverage report

Total: 69.26%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Copy link
Contributor

@louis-menlo louis-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@urmauur urmauur merged commit 231c711 into dev Jan 15, 2025
9 checks passed
@urmauur urmauur deleted the chore/add-chat-completion-field branch January 15, 2025 08:45
@imtuyethan imtuyethan modified the milestones: v0.5.14, v0.5.15 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Maintenance, operational
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Settings Page UI Extension
3 participants