enhancement: Update Cortex page with better description & UX #4416
+139
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barecheck - Code coverage reportTotal: 68.61%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
urmauur
approved these changes
Jan 8, 2025
|
This is the build for this pull request. You can download it from the Artifacts section here: Build URL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR enhances cortex settings page with better description and UX.
Fixed CSS for setting input:
completionstext is cut off at the letter "c" because of extra padding for the reveal password action. However, in the case of normal input, there should be no extra padding since there's no such action.We've resolved the issue where users couldn't scroll to view the complete extension settings page in a narrow window.
Fixes Issues
Cortexpage with better description & UX #4414Cortexpage #4406Self Checklist
This pull request includes changes to improve the settings configuration and UI components in the
inference-cortex-extensionandwebdirectories. The most important changes include enhancements to the default settings descriptions, the addition of a new dropdown component for setting details, and updates to handle dropdowns in the settings UI.Enhancements to default settings descriptions:
extensions/inference-cortex-extension/resources/default_settings.json: Improved descriptions for settings related to continuous batching, parallel operations, CPU threads, flash attention, caching, KV cache type, and MMAP. [1] [2] [3] [4] [5]Addition of new dropdown component:
web/screens/Settings/SettingDetail/SettingDetailItem/SettingDetailDropdownItem/index.tsx: Added a newSettingDetailDropdownItemcomponent to handle dropdown settings, including importing necessary dependencies and defining the component structure.Updates to handle dropdowns in settings UI:
web/screens/Settings/SettingDetail/SettingDetailItem/index.tsx: ImportedSettingDetailDropdownItemand updated theSettingDetailItemcomponent to handle the 'dropdown' case, ensuring the new dropdown component is used for relevant settings. [1] [2]