fix: populate engines, models and legacy settings #4403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urmauur
approved these changes
Jan 5, 2025
|
LGTM |
urmauur
pushed a commit
that referenced
this pull request
Jan 6, 2025
* fix: populate engines, models and legacy settings * chore: legacy logics update configured remote engine
urmauur
pushed a commit
that referenced
this pull request
Jan 6, 2025
* fix: populate engines, models and legacy settings * chore: legacy logics update configured remote engine
louis-menlo
added a commit
that referenced
this pull request
Jan 14, 2025
* fix: populate engines, models and legacy settings * chore: legacy logics update configured remote engine
louis-menlo
added a commit
that referenced
this pull request
Jan 14, 2025
* fix: populate engines, models and legacy settings * chore: legacy logics update configured remote engine
urmauur
added a commit
that referenced
this pull request
Jan 14, 2025
* feat: remote engine management * chore: fix linter issue * chore: remove unused imports * fix: populate engines, models and legacy settings (#4403) * fix: populate engines, models and legacy settings * chore: legacy logics update configured remote engine * fix: check exist path before reading * fix: engines and models persist - race condition * chore: update issue state * test: update test cases * chore: bring back Cortex extension settings * chore: setup button gear / plus based apikey * chore: fix remote engine from welcome screen * chore: resolve linter issue * chore: support request headers template * chore: update engines using header_template instead of api_key_template * chore: update models on changes * fix: anthropic response template * chore: fix welcome screen and debounce update value input * chore: update engines list on changes * chore: update engines list on change * chore: update desc form add modal remote engines * chore: bump cortex version to latest RC * chore: fix linter * fix: transform payload of Anthropic and OpenAI * fix: typo * fix: openrouter model id for auto routing * chore: remove remote engine URL setting * chore: add cohere engine and model support * fix: should not clean on app launch - models list display issue * fix: local engine check logic * chore: bump app version to latest release 0.5.13 * test: fix failed tests --------- Co-authored-by: Louis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR is a stacked PR (sub) of #4364
This PR aims to populate the list of supported remote engines and their respective models. All of the remote engine extensions are removed in this PR.
Fixes Issues
Self Checklist
This pull request includes significant updates to the engine management system, including refactoring the
EngineConfigtype, adding new methods to theEngineManagementExtensionclass, and updating engine model configurations. Additionally, it removes some unused code and updates various type definitions.Engine Management Enhancements:
core/src/browser/extensions/enginesManagement.ts: AddedEngineConfigtype and updated methods to use this type. Introduced new methodsaddRemoteEngineandgetRemoteModels. [1] [2] [3] [4]Code Cleanup:
core/src/node/helper/config.ts: Removed thephysicalCpuCountfunction and related utility code. Simplified logging statements and updated thedefaultAppConfigfunction for better readability. [1] [2] [3] [4] [5]core/src/node/helper/resource.ts: Removed the usage ofphysicalCpuCountand simplified thegetSystemResourceInfofunction.Type Definitions Updates:
core/src/types/engine/index.ts: UpdatedEnginestype to includeEngineConfigand addedEngineMetadataandEngineConfigtypes. [1] [2]core/src/types/message/messageEntity.ts: Addedengineandtypefields toMessageRequestandThreadMessagetypes. UpdatedIncompleteDetailstype for better readability. [1] [2] [3] [4]Engine Models Configuration:
extensions/engine-management-extension/engines.mjs: Added imports for various engine and model JSON files. Consolidated engines and models into arrays for export.anthropic,cohere, andgroqto use a consistent structure and updated fields. [1] [2] [3] [4] [5]