Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: remove redundant animation #3938

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Nov 4, 2024

Describe Your Changes

Remove redundant animation when switch menu on ribbon and left panel

Fixes Issues

Screenshot 2024-11-04 at 10 21 19 Screenshot 2024-11-04 at 10 21 30

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: enhancement Improves a current feature label Nov 4, 2024
@urmauur urmauur requested a review from louis-menlo November 4, 2024 03:26
@urmauur urmauur self-assigned this Nov 4, 2024
@urmauur urmauur force-pushed the ui/switch-list-thread-animation branch from 1597c32 to c9acd46 Compare November 4, 2024 05:47
Copy link
Contributor

@louis-menlo louis-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urmauur urmauur added this to the v0.5.8 milestone Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Barecheck - Code coverage report

Total: 69.38%

Your code coverage diff: -0.01% ▾

Uncovered files and lines
FileLines
web/screens/Thread/ThreadLeftPanel/index.tsx55-56, 73-74, 76, 90-91, 98, 117, 125, 127, 159, 163, 177, 181, 195, 199

@urmauur urmauur merged commit c6481d4 into dev Nov 4, 2024
9 checks passed
@urmauur urmauur deleted the ui/switch-list-thread-animation branch November 4, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improves a current feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

idea: [UX enhancement] Remove redundant animation in Jan
2 participants