Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed download should not be added to download state #3297

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

namchuai
Copy link
Collaborator

@namchuai namchuai commented Aug 7, 2024

Describe Your Changes

  • Previously, we add download state immediately without waiting for result from cortex. Now we only add download state if cortex is accepting that download.

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label Aug 7, 2024
@namchuai namchuai merged commit 8fbb9d2 into fix/error-icon-import-model Aug 7, 2024
2 checks passed
@namchuai namchuai deleted the fix/download-failed branch August 7, 2024 10:48
@github-actions github-actions bot added this to the v.0.6.0 milestone Aug 7, 2024
namchuai added a commit that referenced this pull request Aug 7, 2024
* fix: error while importing local model is not shown

Signed-off-by: James <[email protected]>

* fix: failed download should not be added to download state (#3297)

Signed-off-by: James <[email protected]>

---------

Signed-off-by: James <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants