Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: switch between models get stuck #2698

Merged
merged 1 commit into from
Apr 12, 2024
Merged

fix: switch between models get stuck #2698

merged 1 commit into from
Apr 12, 2024

Conversation

louis-menlo
Copy link
Contributor

Describe Your Changes

  • The model unload promise is not waited on until it's fully unloaded.

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-menlo louis-menlo changed the base branch from dev to release/0.4.11 April 12, 2024 05:20
@louis-menlo louis-menlo requested a review from a team April 12, 2024 05:20
@louis-menlo louis-menlo changed the title Fix/switch between models get stuck fix: switch between models get stuck Apr 12, 2024
@louis-menlo louis-menlo merged commit fa9d8ab into release/0.4.11 Apr 12, 2024
9 checks passed
@louis-menlo louis-menlo deleted the fix/switch-between-models-get-stuck branch April 12, 2024 05:34
@github-actions github-actions bot added this to the v0.4.12 milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@louis-menlo louis-menlo

Labels
None yet
Projects
None yet
Milestone
v0.4.12
Development

Successfully merging this pull request may close these issues.
1 participant
@louis-menlo