Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: race condition issue - reading settings.json file #2683

Merged
merged 3 commits into from
Apr 11, 2024
Merged

fix: race condition issue - reading settings.json file #2683

merged 3 commits into from
Apr 11, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Apr 11, 2024 •
edited
Loading

Describe Your Changes

  • Fixed an issue where the user would get stuck on the 'RESETTING DATA' screen while starting a model
  • Read System Information before settings file is created would raise this error
    Screenshot_2024-04-11_at_13 02 49

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan requested a review from a team April 11, 2024 06:20
@github-actions github-actions bot added the type: bug Something isn't working label Apr 11, 2024
@louis-jan louis-jan force-pushed the regression/fix-error-reading-settings-file branch 5 times, most recently from 902309e to 2dfef69 Compare April 11, 2024 07:54
@louis-jan louis-jan force-pushed the regression/fix-error-reading-settings-file branch from 2dfef69 to bddfab0 Compare April 11, 2024 08:06
@louis-jan louis-jan merged commit 02c49e7 into release/0.4.11 Apr 11, 2024
7 checks passed
@louis-jan louis-jan deleted the regression/fix-error-reading-settings-file branch April 11, 2024 08:37
@github-actions github-actions bot added this to the v0.4.12 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

Assignees

@louis-jan louis-jan

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v0.4.12
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-jan @namchuai