Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: can't read the setting at first time #2677

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix: can't read the setting at first time #2677

merged 1 commit into from
Apr 11, 2024

Conversation

namchuai
Copy link
Collaborator

@namchuai namchuai commented Apr 11, 2024 •
edited
Loading

Describe Your Changes

  • When init, model can't read from the settings folder so we need to provide it with default setting values.

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label Apr 11, 2024
@Van-QA
Copy link
Contributor

Van-QA commented Apr 11, 2024 •
edited
Loading

related to #2644 (comment)

@louis-jan
Copy link
Contributor

@namchuai please update PR's description

louis-jan
louis-jan approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namchuai namchuai merged commit ddb73d8 into dev Apr 11, 2024
9 checks passed
@namchuai namchuai deleted the fix/2644 branch April 11, 2024 03:56
@github-actions github-actions bot added this to the v0.4.11 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees

@namchuai namchuai

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v0.4.11
Development

Successfully merging this pull request may close these issues.
3 participants
@namchuai @Van-QA @louis-jan