Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add fallback as default endpoint for inference engine #2669

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix: add fallback as default endpoint for inference engine #2669

merged 1 commit into from
Apr 10, 2024

Conversation

namchuai
Copy link
Contributor

Describe Your Changes

  • Add default setting as fallback when user removed the endpoint from extension setting.

Screenshots

Screenshot 2024-04-10 at 13 56 13

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai requested a review from louis-menlo April 10, 2024 06:56
@github-actions github-actions bot added the type: bug Something isn't working label Apr 10, 2024
louis-menlo
louis-menlo approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@louis-menlo louis-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Van-QA Van-QA merged commit 8917be5 into dev Apr 10, 2024
7 checks passed
@Van-QA Van-QA deleted the fix/2659 branch April 10, 2024 11:15
@github-actions github-actions bot added this to the v0.4.11 milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-menlo louis-menlo louis-menlo approved these changes

Assignees

@namchuai namchuai

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v0.4.11
Development

Successfully merging this pull request may close these issues.
3 participants
@namchuai @louis-menlo @Van-QA