Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rearrange model position in Hub page #2622

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Rearrange model position in Hub page #2622

merged 3 commits into from
Apr 5, 2024

Conversation

Inchoker
Copy link
Contributor

@Inchoker Inchoker commented Apr 4, 2024 •
edited
Loading

Describe Your Changes

-Rearrange using following condition:

  1. Featured models -> remote models -> local models -> remaining models
  2. Each of categories are sorted by name ascendingly

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@Inchoker Inchoker requested review from namchuai and louis-menlo April 4, 2024 19:30
louis-menlo
louis-menlo approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@louis-menlo louis-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Inchoker Inchoker merged commit 815a7ae into dev Apr 5, 2024
7 checks passed
@Inchoker Inchoker deleted the bug/2532 branch April 5, 2024 17:44
@github-actions github-actions bot added this to the v0.4.11 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-menlo louis-menlo louis-menlo approved these changes

@namchuai namchuai Awaiting requested review from namchuai

Assignees

@Inchoker Inchoker

Labels
None yet
Projects
None yet
Milestone
v0.4.11
Development

Successfully merging this pull request may close these issues.

bug: Hub - The order of models should be: Featured -> Ascending order (Remote -> Local)
2 participants
@Inchoker @louis-menlo