fix: model recommendation label is not based on VRAM #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urmauur
approved these changes
Mar 27, 2024
louis-jan
force-pushed
the
fix/model-recommendation-not-based-vram
branch
from
0442e73 to
4661d87
Compare
louis-jan
force-pushed
the
fix/model-recommendation-not-based-vram
branch
from
4661d87 to
dcf890c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
The model recommendation feature under thread settings in Jan is not accounting for VRAM when GPU acceleration is enabled.
Fixes Issues
Self Checklist