Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Updates Guide Using the Local Server #1924

Merged
merged 9 commits into from
Feb 16, 2024
Merged

docs: Updates Guide Using the Local Server #1924

merged 9 commits into from
Feb 16, 2024

Conversation

SamPatt
Copy link
Contributor

@SamPatt SamPatt commented Feb 5, 2024

Describe Your Changes

  • Fills out the Local Server documentation by adding two pages. Includes screenshots as placeholders; more user-friendly GIFs can be added later.

Fixes Issues

@0xHieu01 0xHieu01 self-requested a review February 6, 2024 00:01
@freelerobot freelerobot added the type: docs Improvements or additions to documentation label Feb 9, 2024
@freelerobot freelerobot changed the title Updates Guide Using the Local Server docs: Updates Guide Using the Local Server Feb 9, 2024
freelerobot
freelerobot approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@freelerobot freelerobot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is AWESOME. Thank you @SamPatt

Something is weird with CI
@hiento09 can you take a look when you're back, and we can get this merged?

@0xHieu01
Copy link
Contributor

I think this is an issue with CI. When outside contributors (not added to repo) folk this repo, and open pull request to it. Cloudflare Pages PR Review and Stagging don't have access to API token. cc: @hiento09

@0xHieu01
Copy link
Contributor

I will merge this PR first and will create a ticket for tracking the CI issue.

cc: @0xSage

@0xHieu01 0xHieu01 merged commit 9fcc341 into janhq:dev Feb 16, 2024
1 check failed
@0xHieu01 0xHieu01 mentioned this pull request Feb 16, 2024
Closed
4 tasks
@Van-QA Van-QA added this to the v0.4.7 milestone Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freelerobot freelerobot freelerobot approved these changes

@0xHieu01 0xHieu01 Awaiting requested review from 0xHieu01

Assignees

@SamPatt SamPatt

Labels
type: docs Improvements or additions to documentation
Projects
Menlo
Archived in project
Milestone
v0.4.7
Development

Successfully merging this pull request may close these issues.

docs: update Guide Using the Local Server
4 participants
@SamPatt @0xHieu01 @freelerobot @Van-QA