Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows uninstall not force close app #4459

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

hiento09
Copy link
Collaborator

Describe Your Changes

  • fix: windows uninstall not force close app

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@hiento09 hiento09 requested a review from a team January 15, 2025 14:21
@hiento09 hiento09 self-assigned this Jan 15, 2025
@github-actions github-actions bot added the type: bug Something isn't working label Jan 15, 2025
@hiento09 hiento09 force-pushed the fix/windows-uninstaller branch from 4fb3b13 to f663754 Compare January 15, 2025 14:22
Copy link
Contributor

Barecheck - Code coverage report

Total: 69.24%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Copy link
Contributor

@louis-menlo louis-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's gooo

@hiento09 hiento09 merged commit 63c938e into dev Jan 15, 2025
14 checks passed
@hiento09 hiento09 deleted the fix/windows-uninstaller branch January 15, 2025 15:05
@github-actions github-actions bot added this to the v0.5.14 milestone Jan 15, 2025
Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@imtuyethan imtuyethan modified the milestones: v0.5.14, v0.5.15 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: [0.5.12] Uninstalling Jan doesn't close the app
3 participants