Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: [0.5.12] Uninstalling Jan doesn't close the app #4411

Closed
1 of 3 tasks
TC117 opened this issue Jan 7, 2025 · 1 comment · Fixed by #4459
Closed
1 of 3 tasks

bug: [0.5.12] Uninstalling Jan doesn't close the app #4411

TC117 opened this issue Jan 7, 2025 · 1 comment · Fixed by #4459
Assignees
@louis-menlo @hiento09
Labels
type: bug Something isn't working
Milestone
v0.5.15

Comments

@TC117
Copy link

TC117 commented Jan 7, 2025

Jan version

0.5.13

Describe the Bug

Uninstall Jan not close the current app window
image

Steps to Reproduce

No response

Screenshots / Logs

No response

What is your OS?

  • MacOS
  • Windows
  • Linux
@TC117 TC117 added the type: bug Something isn't working label Jan 7, 2025
@github-project-automation github-project-automation bot moved this to Investigating in Menlo Jan 7, 2025
@imtuyethan imtuyethan changed the title bug: Uninstall Jan not close the app bug: Uninstall Jan doesn't close the app Jan 7, 2025
@imtuyethan imtuyethan changed the title bug: Uninstall Jan doesn't close the app bug: [0.5.12] Uninstalling Jan doesn't close the app Jan 7, 2025
@imtuyethan imtuyethan added this to the v0.5.15 milestone Jan 7, 2025
@louis-menlo
Copy link
Contributor

Looks like it need a custom uninstaller cc @hiento09

https://medium.com/@darshitshah8/how-to-close-a-running-electron-app-and-uninstall-appdata-using-nsis-on-uninstallation-dfb658b3853d

@hiento09 hiento09 moved this from Investigating to Planning in Menlo Jan 14, 2025
@louis-menlo louis-menlo moved this from Planning to Investigating in Menlo Jan 14, 2025
@hiento09 hiento09 moved this from Investigating to In Progress in Menlo Jan 15, 2025
@hiento09 hiento09 mentioned this issue Jan 15, 2025
Merged
3 tasks
@hiento09 hiento09 moved this from In Progress to Eng Review in Menlo Jan 15, 2025
@github-project-automation github-project-automation bot moved this from Eng Review to QA in Menlo Jan 15, 2025
@imtuyethan imtuyethan modified the milestones: v0.5.15, v0.5.16 Jan 21, 2025
@hiento09 hiento09 moved this from QA to Completed in Menlo Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louis-menlo louis-menlo

@hiento09 hiento09

Labels
type: bug Something isn't working
Projects
Menlo
Archived in project
Milestone
v0.5.15
Development

Successfully merging a pull request may close this issue.

fix: windows uninstall not force close app janhq/jan
4 participants
@TC117 @imtuyethan @louis-menlo @hiento09