Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Import public model via Huggingface URL #1740

Closed
Tracked by #1773
imtuyethan opened this issue Jan 24, 2024 · 3 comments
Closed
Tracked by #1773

feat: Import public model via Huggingface URL #1740

imtuyethan opened this issue Jan 24, 2024 · 3 comments
Assignees
Labels
P1: important Important feature / fix type: feature request A new feature
Milestone

Comments

@imtuyethan
Copy link
Contributor

imtuyethan commented Jan 24, 2024

Specs: https://www.notion.so/jan-ai/Model-Hub-can-Import-from-HuggingFace-225dd4da88944bc183b816922c3333a8?pvs=4


User Flow: Import Model via Huggingface URL

  1. Copy Huggingface URL & Paste into Search Bar: Copy the link of the model repo from Huggingface, pasting it to search bar in Hub or My models page.
Screenshot 2024-01-24 at 2 00 47 PM
  1. Repo Search: Jan will automatically search the repository linked to the provided Huggingface URL.

  2. Scan for GGUF Files: The application scans for available GGUF files associated with the provided Huggingface model.

Screenshot 2024-01-24 at 2 01 19 PM
  1. Model Card & Files Preview: You'll see a nicely-formatted model card reflecting all available model files to decide which one you want to import to Jan.
Screenshot 2024-01-24 at 2 02 11 PM
  1. Import and Generate model.json: Jan proceeds to download the identified files and generates the necessary model.json for seamless integration.

6. Design

Figma link:
https://www.figma.com/file/ytn1nRZ17FUmJHTlhmZB9f/Jan-App?type=design&node-id=3009-127260&mode=design&t=ZlK57CWtREqzmEZu-4

@hiro-v
Copy link
Contributor

hiro-v commented Jan 30, 2024

@louis-jan @namchuai This script: https://github.com/ggerganov/llama.cpp/blob/master/scripts/server-llm.sh#L223 contains the logic to parse .gguf models as list from a given huggingface URL (We can use huggingface model handler).
Hope it helps

btw @imtuyethan - Normally people paste the HuggingFace model handler, not the full URL
e.g: The link - https://huggingface.co/TheBloke/Mistral-7B-v0.1-GGUF -> People usually use TheBloke/Mistral-7B-v0.1-GGUF instead. Technically we can construct the URL to use underneath

@Van-QA Van-QA modified the milestones: v0.4.7, v0.4.8 Feb 17, 2024
@Van-QA Van-QA modified the milestones: v0.4.8, v0.4.10 Mar 1, 2024
@Van-QA Van-QA modified the milestones: v0.4.10, v0.4.11 Mar 25, 2024
@louis-menlo louis-menlo removed their assignment Apr 5, 2024
@Van-QA Van-QA mentioned this issue Apr 5, 2024
10 tasks
@imtuyethan imtuyethan changed the title feat: Implement import model via Huggingface URL epic: Implement import model via Huggingface URL Apr 9, 2024
@imtuyethan imtuyethan added type: epic A major feature or initiative and removed type: feature request A new feature labels Apr 9, 2024
@imtuyethan imtuyethan changed the title epic: Implement import model via Huggingface URL epic: Import model via Huggingface URL Apr 9, 2024
@imtuyethan imtuyethan moved this from Planned to In Progress in Menlo Apr 9, 2024
@Van-QA Van-QA modified the milestones: v0.4.11, v0.4.12 Apr 9, 2024
@namchuai namchuai moved this from In Progress to In Review in Menlo Apr 11, 2024
@Van-QA
Copy link
Contributor

Van-QA commented Apr 12, 2024

@namchuai

  1. Correct downloaded to Use button
    image

  2. Loader icon
    loadHF

  3. Allow pressing Enter to reload the URL to view the popup
    image

  4. UI broke due to many tags
    image

@namchuai namchuai moved this from In Review to QA in Menlo Apr 15, 2024
@Van-QA Van-QA changed the title epic: Import model via Huggingface URL feat: Import public model via Huggingface URL Apr 19, 2024
@Van-QA Van-QA added type: feature request A new feature and removed type: epic A major feature or initiative labels Apr 19, 2024
@Van-QA
Copy link
Contributor

Van-QA commented Apr 19, 2024

  1. Duplicate HF model id input ❌ need clearer msg @namchuai, thank you
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1: important Important feature / fix type: feature request A new feature
Projects
Archived in project
Development

No branches or pull requests

6 participants