Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epic: Users can import model binaries via Jan UI #1230

Closed
3 of 4 tasks
freelerobot opened this issue Dec 27, 2023 · 5 comments
Closed
3 of 4 tasks

epic: Users can import model binaries via Jan UI #1230

freelerobot opened this issue Dec 27, 2023 · 5 comments
Assignees
Labels
needs designs Needs designs type: epic A major feature or initiative
Milestone

Comments

@freelerobot
Copy link
Contributor

freelerobot commented Dec 27, 2023

Motivation

Address the top user complaint by streamlining the model import process in Jan. Current formats and approaches hinder user experience, especially for non-technical users.

Goals and Success Criteria

2.1. Goals

  • Enhance user experience by simplifying the model import process.
  • Alleviate the number one user complaint regarding model import.

2.2.Success Criteria

  • Enable users to seamlessly import models through clicking to add or drag-and-drop functionality.
  • Provide flexibility for users to import models from both folders and individual files.
  • Allow users to customize default configurations through an autogenerated model.json file.
  • Utilize symlinks to prevent the models folder from occupying excessive user storage space.

User Flow

1. Import Model via GUI:

  1. Initiate Import: Access the "Import Model" feature through the Jan application interface whether clicking to add or drag and drop a model file or folder into the application window.

  2. Automatic Scan (Folder Import): (in case users import a folder) If a folder is dropped, Jan automatically scans for multiple model files (GGUF format).

  3. Choose Import Method:

    • Prompt users to choose their preferred import method:
      • a. Duplicate Folder:
        • If users want to maintain a separate model folder within Jan (may consume additional storage).
      • b. Use Symlinks:
        • If users want to avoid duplicating the model folder to save storage (requires understanding symlinks).
  4. Importing model: Users are presented with an import interface, showing progress, cancel, and remove file options.

  5. Autogenerated model.json (Folder Import): For each model found, Jan generates a corresponding model.json in Jan Data Folder.

  6. Optional Model Configuration: Users have the option to fill in additional properties in the model.json for more detailed configurations.

2. Import Model Manually

  • For users who manually add models located at specific paths (for example: User opts to add only the model located at /random_path/model to Jan), Jan won't automatically scan these models every time you open the app.

  • For this case: Users need to use the "Refresh" button to manually re-scan and integrate any models they have manually added outside of the automatic scanning process.

6. Design

Figma link:
https://www.figma.com/file/ytn1nRZ17FUmJHTlhmZB9f/Jan-App?type=design&node-id=2160-165286&mode=design&t=TdZv1LIEiCArXNOZ-4

Image

Tasklist

Design

Implementation

Further questions:

  • Clearly articulate how default values in the model.json fields will be handled.
  • Determine whether the app necessitates a restart after the model binary is relocated into /models.

Out-of-scope

  • Only support GGUF format for now, other model file format Jan won't support.
  • Import model via Huggingface URL
@freelerobot freelerobot added this to the v0.4.4 milestone Dec 27, 2023
@freelerobot freelerobot modified the milestones: v0.4.4, v0.5.0 Dec 27, 2023
@freelerobot freelerobot changed the title feat: users can import models via Jan UI feat: users can import (downloaded) model binaries via Jan UI Dec 27, 2023
@freelerobot freelerobot added type: epic A major feature or initiative and removed type: feature request A new feature labels Dec 27, 2023
@freelerobot freelerobot changed the title feat: users can import (downloaded) model binaries via Jan UI epic: users can import (downloaded) model binaries via Jan UI Dec 27, 2023
@imtuyethan imtuyethan moved this to In Progress in Menlo Jan 4, 2024
@imtuyethan imtuyethan changed the title epic: users can import (downloaded) model binaries via Jan UI epic: users can import (downloaded) model binaries via Jan UI and import model from HF link Jan 4, 2024
@imtuyethan imtuyethan changed the title epic: users can import (downloaded) model binaries via Jan UI and import model from HF link epic: users can import (downloaded) model binaries via Jan UI Jan 5, 2024
@imtuyethan imtuyethan moved this from In Progress to In Review in Menlo Jan 10, 2024
@imtuyethan
Copy link
Contributor

@imtuyethan
Copy link
Contributor

Archive Nicole's original comment:


Problem

Success Criteria

  1. Users can drag and drop a model binary
  2. Users can confirm directly (without step 3)
  3. Optionally: Users have the option of filling in the other properties in the model.json

Specs

  • TODO: define field defaulting behavior
  • Define folder creation & path behavior
  • Figure out if app needs to restart after model binary is moved into /models @louis-jan ?

Designs:

Additional context
Add any other context or screenshots about the feature request here.

@imtuyethan imtuyethan moved this from In Review to Planned in Menlo Jan 18, 2024
@imtuyethan imtuyethan modified the milestones: v0.5.0, v0.4.6 Jan 18, 2024
@imtuyethan imtuyethan moved this from Planned to In Progress in Menlo Jan 18, 2024
@imtuyethan imtuyethan moved this from In Progress to Planned in Menlo Jan 22, 2024
@imtuyethan imtuyethan modified the milestones: v0.4.6, v0.4.7 Jan 24, 2024
@imtuyethan
Copy link
Contributor

Remove huggingface...

@imtuyethan imtuyethan changed the title epic: users can import (downloaded) model binaries via Jan UI epic: Users can import (downloaded) model binaries via Jan UI Jan 25, 2024
@imtuyethan imtuyethan changed the title epic: Users can import (downloaded) model binaries via Jan UI epic: Users can import model binaries via Jan UI Jan 25, 2024
@imtuyethan imtuyethan modified the milestones: v0.4.7, v0.4.8 Jan 29, 2024
@imtuyethan imtuyethan assigned urmauur and unassigned imtuyethan Feb 16, 2024
@urmauur urmauur moved this from Planned to In Progress in Menlo Feb 21, 2024
@namchuai namchuai moved this from In Progress to In Review in Menlo Feb 23, 2024
@namchuai namchuai moved this from In Review to QA in Menlo Feb 26, 2024
@namchuai
Copy link
Contributor

@Van-QA , please help to validate this issue. Thank you!

@namchuai namchuai assigned Van-QA and unassigned urmauur and namchuai Feb 26, 2024
@Van-QA
Copy link
Contributor

Van-QA commented Mar 11, 2024

Tested and looking good on Jan 0.4.7-304 ✅

@Van-QA Van-QA closed this as completed Mar 11, 2024
@github-project-automation github-project-automation bot moved this from QA to Done in Menlo Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs designs Needs designs type: epic A major feature or initiative
Projects
Archived in project
Development

No branches or pull requests

5 participants