fix: temporary disable warm up for deepseek-r1 #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vansangpfiev
pushed a commit
that referenced
this pull request
Feb 3, 2025
This reverts commit e51e22c.
vansangpfiev
pushed a commit
that referenced
this pull request
Feb 3, 2025
vansangpfiev
pushed a commit
that referenced
this pull request
Feb 3, 2025
vansangpfiev
pushed a commit
that referenced
this pull request
Feb 3, 2025
This reverts commit e51e22c.
vansangpfiev
added a commit
that referenced
this pull request
Feb 3, 2025
This reverts commit e51e22c. Co-authored-by: vansangpfiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
src/llama_engine.ccfile to handle specific model types and improve the inference process. The most important changes are:Model handling improvements:
src/llama_engine.cc: Added a condition to skip the warm-up process for models with IDs containing "deepseek-r1".Inference process enhancements:
src/llama_engine.cc: Modified theHandleInferenceImplmethod to append a specific end-of-sentence marker for models with IDs containing "deepseek-r1" when the input role is "assistant".