Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codesign macos for application and installer #974

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Fix codesign macos for application and installer #974

merged 1 commit into from
Aug 5, 2024

Conversation

hiento09
Copy link
Contributor

@hiento09 hiento09 commented Aug 5, 2024

Describe Your Changes

  • Fix codesign macos for application and installer

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@hiento09 hiento09 requested a review from louis-jan August 5, 2024 08:36
@hiento09 hiento09 force-pushed the fix/codesign-notarize-macos branch from 4d4dba6 to 6409020 Compare August 5, 2024 08:37
louis-jan
louis-jan approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@hiento09 hiento09 merged commit bb55bb8 into dev Aug 5, 2024
1 check passed
@hiento09 hiento09 deleted the fix/codesign-notarize-macos branch August 5, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiento09 @louis-jan