Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: destroy dangling processes on uninstall #945

Merged
merged 1 commit into from
Jul 31, 2024
Merged

chore: destroy dangling processes on uninstall #945

merged 1 commit into from
Jul 31, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Jul 30, 2024 •
edited
Loading

Describe Your Changes

  • Attempt Destroy cpp and js processes on uninstall

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan requested a review from marknguyen1302 July 30, 2024 17:05
@louis-jan louis-jan merged commit 979be8b into dev Jul 31, 2024
2 checks passed
@louis-jan louis-jan deleted the chore/destroy-dangling-process-on-uninstall branch July 31, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marknguyen1302 marknguyen1302 marknguyen1302 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-jan @marknguyen1302