Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove --options max-old-space-size=30720,tls-min-v1.0,expose-gc pkg #902

Merged
merged 1 commit into from
Jul 23, 2024
Merged

remove --options max-old-space-size=30720,tls-min-v1.0,expose-gc pkg #902

merged 1 commit into from
Jul 23, 2024

Conversation

hiento09
Copy link
Contributor

Describe Your Changes

  • remove --options max-old-space-size=30720,tls-min-v1.0,expose-gc pkg

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@hiento09 hiento09 requested review from namchuai and louis-jan July 22, 2024 11:25
@hiento09 hiento09 force-pushed the chore/remove-pkg-option branch 2 times, most recently from 9adc032 to 9c2cbb1 Compare July 22, 2024 13:03
@hiento09 hiento09 force-pushed the chore/remove-pkg-option branch from 9c2cbb1 to f57ebcc Compare July 23, 2024 10:03
@hiento09 hiento09 requested a review from Van-QA July 23, 2024 10:07
Van-QA
Van-QA approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@Van-QA Van-QA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiento09 hiento09 merged commit 349e57f into dev Jul 23, 2024
2 checks passed
@hiento09 hiento09 deleted the chore/remove-pkg-option branch July 23, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Van-QA Van-QA Van-QA approved these changes

@namchuai namchuai Awaiting requested review from namchuai

@louis-jan louis-jan Awaiting requested review from louis-jan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiento09 @Van-QA