Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove serve command #896

Merged
merged 10 commits into from
Jul 22, 2024
Merged

Remove serve command #896

merged 10 commits into from
Jul 22, 2024

Conversation

marknguyen1302
Copy link
Contributor

Describe Your Changes

  • remove the serve command
  • change the serve command to root
  • require server online for every command
  • detach mode by default

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@marknguyen1302 marknguyen1302 requested a review from louis-jan July 18, 2024 19:44
@louis-jan
Copy link
Contributor

Should not log JS endpoint

Screenshot 2024-07-22 at 09 48 37

@louis-jan
Copy link
Contributor

Start with a custom port, could not stop?

Screenshot 2024-07-22 at 09 54 25

@marknguyen1302 marknguyen1302 requested a review from louis-jan July 22, 2024 04:10
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marknguyen1302 marknguyen1302 merged commit 9857448 into dev Jul 22, 2024
2 checks passed
@marknguyen1302 marknguyen1302 deleted the feat/remove-serve-command branch July 22, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants