Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cortex-cpp node prebuild dependencies #879

Merged
merged 2 commits into from
Jul 15, 2024
Merged

fix: cortex-cpp node prebuild dependencies #879

merged 2 commits into from
Jul 15, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Jul 13, 2024 •
edited
Loading

Describe Your Changes

  • Fixed an issue where the cortex-cpp prebuild was installed without dependencies.
  • Fixed an issue where cortex pulls the incorrect cortex.llamacpp engine file on devices that do not support CUDA.
  • Fixed an issue where the CI fails if the npm module has not been published yet.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan requested a review from marknguyen1302 July 13, 2024 08:19
@louis-jan louis-jan force-pushed the fix/cortex-cpp-node-dependencies branch from 92b6dc2 to e05286d Compare July 13, 2024 08:53
@louis-jan louis-jan force-pushed the fix/cortex-cpp-node-dependencies branch from e05286d to 50dde9a Compare July 13, 2024 16:49
@louis-jan louis-jan merged commit 69ba031 into dev Jul 15, 2024
6 checks passed
@louis-jan louis-jan deleted the fix/cortex-cpp-node-dependencies branch July 15, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marknguyen1302 marknguyen1302 marknguyen1302 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: cortex is missing zlib.dll file
2 participants
@louis-jan @marknguyen1302