Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix openai collection test #874

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Fix openai collection test #874

merged 5 commits into from
Jul 12, 2024

Conversation

hiento09
Copy link
Contributor

Describe Your Changes

  • Fix openai collection test

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@hiento09 hiento09 requested review from Van-QA and louis-menlo July 12, 2024 03:45
@hiento09 hiento09 force-pushed the fix/openai branch 4 times, most recently from 60dbd5d to 8ed7df2 Compare July 12, 2024 04:05
Van-QA
Van-QA approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@Van-QA Van-QA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Van-QA Van-QA merged commit 9ed712b into dev Jul 12, 2024
2 checks passed
@Van-QA Van-QA deleted the fix/openai branch July 12, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Van-QA Van-QA Van-QA approved these changes

@louis-menlo louis-menlo Awaiting requested review from louis-menlo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hiento09 @Van-QA @vansangpfiev @jan-service-account