Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean resources should not remove engine file #867

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix: clean resources should not remove engine file #867

merged 1 commit into from
Jul 10, 2024

Conversation

louis-jan
Copy link
Contributor

Describe Your Changes

  • Should not clean engine resources

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan requested a review from marknguyen1302 July 10, 2024 09:11
@marknguyen1302 marknguyen1302 merged commit 31b172b into dev Jul 10, 2024
1 check passed
@marknguyen1302 marknguyen1302 deleted the fix/clean-resources-keep-engine-file branch July 10, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marknguyen1302 marknguyen1302 marknguyen1302 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-jan @marknguyen1302