Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the URL and API desc #785

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Update the URL and API desc #785

merged 5 commits into from
Jun 28, 2024

Conversation

irfanpena
Copy link
Contributor

Describe Your Changes

  • Update the URL and API desc

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@irfanpena irfanpena requested a review from louis-jan June 27, 2024 03:27
@irfanpena irfanpena self-assigned this Jun 27, 2024
@louis-jan
Copy link
Contributor

louis-jan commented Jun 27, 2024

Sorry @irfanpena, since you are working on this, please help on this as well:

These chat/completion parameters do not work with the TensorRT-LLM engine:

  • frequency_penalty
  • presence_penalty
  • top_p

Also when I try the Playground, Post chat/completions example gives a weird messages structure.

messages: [ string ] where it should be

"messages": [
    {
        "role: "user"
        "content: "hello"
    }
]

Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louis-jan louis-jan merged commit bd8968a into dev Jun 28, 2024
1 check passed
@louis-jan louis-jan deleted the docs/api-update branch June 28, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants