Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cortex serve should run in attached mode by default #711

Merged
merged 1 commit into from
Jun 17, 2024
Merged

fix: cortex serve should run in attached mode by default #711

merged 1 commit into from
Jun 17, 2024

Conversation

louis-menlo
Copy link
Contributor

Describe Your Changes

  • As a user, when I run cortex serve, I would like to see it run in attached mode, allowing me to observe the incoming requests

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-menlo louis-menlo merged commit b77fb70 into dev Jun 17, 2024
1 check failed
@louis-menlo louis-menlo deleted the fix/serve-attached-mode-default branch June 17, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marknguyen1302 marknguyen1302 marknguyen1302 approved these changes

@namchuai namchuai Awaiting requested review from namchuai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-menlo @marknguyen1302