Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: failed tests #702

Merged
merged 3 commits into from
Jun 17, 2024
Merged

fix: failed tests #702

merged 3 commits into from
Jun 17, 2024

Conversation

louis-menlo
Copy link
Contributor

Describe Your Changes

  • Fix failed tests due to the introduction of the new Download Manager module

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Van-QA
Van-QA approved these changes Jun 16, 2024
View reviewed changes
Copy link
Contributor

@Van-QA Van-QA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louis-menlo louis-menlo merged commit 2702751 into dev Jun 17, 2024
@louis-menlo louis-menlo deleted the fix/failed-tests branch June 17, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marknguyen1302 marknguyen1302 marknguyen1302 approved these changes

@Van-QA Van-QA Van-QA approved these changes

@namchuai namchuai Awaiting requested review from namchuai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louis-menlo @Van-QA @marknguyen1302