feat: add cortex serve detach option - add health check and stop api endpoints #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marknguyen1302
approved these changes
Jun 15, 2024
louis-jan
force-pushed
the
feat/cortex-serve-attach-detach
branch
from
33c0f65 to
eed17d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR is intended to refactor the use cases to eliminate their dependency on controllers. According to the principles of the Clean Architecture, controllers should be defined at the app/framework level and not in the use cases.
This PR also added support for Cortex Serve with detach mode and additional status indicators in Cortex PS to display the API server's online status. Also added stop api server option
cortex serve stop.Fixes Issues
Self Checklist