Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cortex run attempt to pull model #662

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Cortex run attempt to pull model #662

merged 3 commits into from
Jun 6, 2024

Conversation

louis-menlo
Copy link
Contributor

@louis-menlo louis-menlo commented Jun 5, 2024 •
edited
Loading

Describe Your Changes

  1. cortex run some_model
  2. some_model doesn't exist locally & exists in the our model hub on hugging face
  3. infer the pull step and execute it

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-menlo
fix: model run should try pull if model is not downloaded
b5d2ac6
@louis-menlo
chore: cortex pull includes cortex pull when necessary
6200cce 
# Conflicts:
#	cortex-js/src/infrastructure/commanders/shortcuts/run.command.ts
@louis-menlo louis-menlo merged commit 31f5e14 into dev Jun 6, 2024
@louis-menlo louis-menlo deleted the cortex-run-attempt-to-pull-model branch June 6, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

@marknguyen1302 marknguyen1302 Awaiting requested review from marknguyen1302

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-menlo @namchuai