Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cortex chat enhancement #631

Merged
merged 1 commit into from
May 30, 2024

Conversation

louis-menlo
Copy link
Contributor

@louis-menlo louis-menlo commented May 30, 2024

Describe Your Changes

  • Improved the cortex chat command to be smarter:
    • cortex chat without model_id: looks for an active running model or selects a running model from the list.
    • cortex chat message and cortex chat -m message work the same (and do not look for a non-existent model with that input).
  • Fixed an issue where Cortex is killed after a chat session ends.
  • Fixed an issue where stopping a model also kills Cortex.
Screenshot 2024-05-30 at 11 39 35 Screenshot 2024-05-30 at 11 40 44

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-menlo louis-menlo force-pushed the chore/cortex-models-chat-enhancement branch from d9da79d to f24c939 Compare May 30, 2024 04:44
@louis-menlo louis-menlo merged commit f0e9a7a into dev May 30, 2024
@louis-menlo louis-menlo deleted the chore/cortex-models-chat-enhancement branch May 30, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants