Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove parameter for run command #602

Merged
merged 1 commit into from
May 23, 2024
Merged

chore: remove parameter for run command #602

merged 1 commit into from
May 23, 2024

Conversation

namchuai
Copy link
Collaborator

Describe Your Changes

  • Remove model param from run command.

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai marked this pull request as ready for review May 23, 2024 05:44
@namchuai namchuai requested a review from louis-jan May 23, 2024 05:44
louis-jan
louis-jan approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namchuai namchuai merged commit 3a26ee0 into dev May 23, 2024
@louis-jan louis-jan deleted the chore/remove-parameter-for-run-command branch July 8, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namchuai @louis-jan