Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.tar.gz PowerShell issues fix. #373

Merged
merged 5 commits into from
Feb 19, 2024
Merged

.tar.gz PowerShell issues fix. #373

merged 5 commits into from
Feb 19, 2024

Conversation

MauroDruwel
Copy link
Contributor

Pull Request: Update install.bat for Compatibility with .tar.gz Extension in PowerShell

Overview

This pull request addresses a compatibility issue with the .tar.gz extension in PowerShell. It incorporates the fix from issue #234 in a more streamlined manner.

Details

The install.bat file has been updated to prevent compatibility issues with the .tar.gz extension when using PowerShell. This change enhances the user experience by preventing potential errors during the installation process.

Conclusion

This pull request provides a necessary update to the install.bat file, improving compatibility with PowerShell.

Update install.bat so there isn't a compatibility issue with the .tar.gz extension in powershell.
@hiro-v hiro-v requested a review from hiento09 January 24, 2024 02:21
@hiro-v hiro-v assigned hiro-v and MauroDruwel and unassigned hiro-v Jan 24, 2024
@hiro-v hiro-v added the type: bug Something isn't working label Jan 24, 2024
@tikikun tikikun requested a review from hiro-v January 30, 2024 01:03
@hiro-v
Copy link
Contributor

hiro-v commented Jan 30, 2024

Thank you for the contribution @MauroDruwel

However, I have tried to run the new install.bat file but cannot call nitro directly from the terminal (powershell and cmd).
Could you have a look as well.

The part for mkdir and tar is good

@MauroDruwel
Copy link
Contributor Author

MauroDruwel commented Jan 30, 2024

Yeah I will check that! My pull request was just to fix this issue:
image
But I now see that I can't call nitro directly from the terminal. But I also couldn't with the old install.bat XD

Thank you for the contribution @MauroDruwel

However, I have tried to run the new install.bat file but cannot call nitro directly from the terminal (powershell and cmd). Could you have a look as well.

The part for mkdir and tar is good

@hiro-v
Copy link
Contributor

hiro-v commented Jan 31, 2024

I see, for the changed part it's okay

@MauroDruwel
Copy link
Contributor Author

Hi @hiro-v, I think I fixed it :) Atleast, it works on my pc. Could you try it? The problem was that the extracting was not saving the files in the %AppData%\nitro folder. But now it works :)

@hiro-v hiro-v removed their request for review February 11, 2024 05:48
Copy link
Contributor

@hiento09 hiento09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
works on my end!

@hiro-v hiro-v merged commit 2cb0900 into janhq:main Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants