Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request introduces significant changes to the CPU information reporting functionality in the codebase. The primary goal is to add CPU usage metrics to the existing hardware information.
Enhancements to CPU Information Reporting:
engine/cli/commands/hardware_list_cmd.cc
: Added a new "Usage" column to the CPU information table and included CPU usage in the row data. [1] [2]engine/common/hardware_common.h
: Added ausage
field to theCPU
struct and updated theToJson
andFromJson
functions to handle the newusage
field. [1] [2] [3]Codebase Refactoring:
engine/common/hardware_common.h
: Moved the#include <assert.h>
directive to the top of the file for better organization.engine/common/hardware_common.h
: Removed unnecessary blank lines and added missing namespace closing comments for better readability. [1] [2] [3]CPU Usage Calculation:
engine/utils/hardware/cpu_info.h
: Integrated theGetCPUUsage
function to retrieve CPU usage metrics and included it in theGetCPUInfo
function. [1] [2]engine/utils/hardware/cpu_usage.h
: Added a new header file to implement theGetCPUUsage
function for different operating systems (Windows, macOS, Linux).Fixes Issues
Self Checklist