Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: manually add http date header for windows #1721

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix: manually add http date header for windows #1721

merged 1 commit into from
Nov 26, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Nov 25, 2024 •
edited
Loading

Describe Your Changes

  • On Windows we set locale to local when convert wstring to std::string. This impacts date field in drogon http header, should add the date as specified in RFC 1123.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review November 25, 2024 10:13
@vansangpfiev vansangpfiev requested a review from a team November 25, 2024 10:13
namchuai
namchuai approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ thank you!

@vansangpfiev vansangpfiev merged commit ad5ecc1 into dev Nov 26, 2024
10 checks passed
@vansangpfiev vansangpfiev deleted the fix/locale-drogon branch November 26, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vansangpfiev @namchuai