Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set progress bar width base on terminal width #1713

Merged
merged 4 commits into from
Nov 22, 2024
Merged

fix: set progress bar width base on terminal width #1713

merged 4 commits into from
Nov 22, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Nov 21, 2024 •
edited
Loading

Describe Your Changes

  • As the title

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev force-pushed the fix/progress-bar-width branch from bfaf44a to e82fdf5 Compare November 21, 2024 04:32
@vansangpfiev vansangpfiev marked this pull request as ready for review November 21, 2024 05:55
@vansangpfiev vansangpfiev requested a review from a team November 21, 2024 05:55
@vansangpfiev vansangpfiev force-pushed the fix/progress-bar-width branch from 5090acd to 049187a Compare November 22, 2024 00:15
@vansangpfiev vansangpfiev force-pushed the fix/progress-bar-width branch 3 times, most recently from 788695e to a3121f9 Compare November 22, 2024 01:37
@vansangpfiev vansangpfiev force-pushed the fix/progress-bar-width branch from a3121f9 to 2160fd4 Compare November 22, 2024 01:43
namchuai
namchuai approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@vansangpfiev vansangpfiev merged commit 8db7e9c into dev Nov 22, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/progress-bar-width branch November 22, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vansangpfiev @namchuai @sangjanai